Hi! I disagree.
If there is an existing extended partition and the user does not instruct parted to do any changes to it, then parted should leave it alone. Example: Well, the same as yours. You told parted to set the boot flag on partition one. You did not say to change anything in any other partition. Why rely on some data-presence detection, when you can simply leave it as it is ? Regards, David -----Original Message----- From: Petr Uzel <[email protected]> To: [email protected] Date: Fri, 23 Jan 2009 13:58:27 +0100 Subject: Re: [parted-devel] [PATCH] Do not discard bootcode from extended partition > On Fri, Jan 23, 2009 at 12:41:39PM +0000, James Courtier-Dutton wrote: > > I thought that valid boot sectors have a checksum or some kind of > > signature bytes. > > Do you mean the 0xAA55 MBR signature? > > > It might be worth verifying that it is a valid boot > > sector before blindly using it. If it is not a valid boot sector, one > > might as well fill it with zeros. > > Definitely - it should be simpler than checking whether we're creating > new extended partition or modifying existing one. > > > > -- > Best regards / s pozdravem > > Petr Uzel, Packages maintainer > --------------------------------------------------------------------- > SUSE LINUX, s.r.o. e-mail: [email protected] > Lihovarská 1060/12 tel: +420 284 028 964 > 190 00 Prague 9 fax: +420 284 028 951 > Czech Republic http://www.suse.cz > > _______________________________________________ > parted-devel mailing list > [email protected] > http://lists.alioth.debian.org/mailman/listinfo/parted-devel _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
