Here's the bug: http://www.paraview.org/Bug/view.php?id=15126 Patch attached. Thanks for reporting this.
Utkarsh On Thu, Nov 13, 2014 at 10:31 AM, Utkarsh Ayachit <[email protected]> wrote: > Found it...I'll send a patch soon. > > On Thu, Nov 13, 2014 at 10:15 AM, Utkarsh Ayachit > <[email protected]> wrote: >> I can reproduce it. I am flummoxed too. Looking into it. >> >> On Thu, Nov 13, 2014 at 6:03 AM, Federico Veronesi >> <[email protected]> wrote: >>> Dear Paraview users, >>> >>> I found an unexpected behavior in Paraview 4.2. >>> When I set separated panels or other options except the combined one, I >>> don't get what it is expected and 6 grayed button (restore, update) appear. >>> >>> I think I fixed it by adding the following lines to pqPropertiesPanel.cxx in >>> the setPanelMode method: >>> >>> // added to avoid unwanted update restore buttons >>> >>> this->Internals->Ui.PropertiesSaveAsDefaults->setVisible(has_source); >>> >>> this->Internals->Ui.PropertiesRestoreDefaults->setVisible(has_source); >>> >>> this->Internals->Ui.DisplaySaveAsDefaults->setVisible(has_display); >>> >>> this->Internals->Ui.DisplayRestoreDefaults->setVisible(has_display); >>> >>> this->Internals->Ui.ViewSaveAsDefaults->setVisible(has_view); >>> >>> this->Internals->Ui.ViewRestoreDefaults->setVisible(has_view); >>> >>> >>> Moreover I modified the paraview main window to setup the panels. i.e. for >>> ALL_SEPARATE: >>> >>> case vtkPVGeneralSettings::ALL_SEPARATE: >>> >>> this->Internals->propertiesPanel->setPanelMode( >>> pqPropertiesPanel::SOURCE_PROPERTIES); >>> >>> // added >>> >>> this->Internals->viewPropertiesPanel->setPanelMode( >>> pqPropertiesPanel::VIEW_PROPERTIES); >>> >>> >>> this->Internals->displayPropertiesPanel->setPanelMode(pqPropertiesPanel::DISPLAY_PROPERTIES); >>> >>> >>> >>> It works at start up, but when I use more than one source the display panel >>> doesn't show any property when switching from one source to another. >>> >>> Do you know what can cause this behavior and how to possibly solve it? >>> >>> >>> Thank you >>> >>> >>> Federico >>> >>> >>> P.S. sorry if I sent this mail previously on paraview-developers, but may be >>> it was the wrong list. >>> >>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Please keep messages on-topic and check the ParaView Wiki at: >>> http://paraview.org/Wiki/ParaView >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/paraview >>>
From 6c22d8832872d5f35c0f6ccb67b1666cad1ce00b Mon Sep 17 00:00:00 2001 From: Utkarsh Ayachit <[email protected]> Date: Thu, 13 Nov 2014 10:59:45 -0500 Subject: [PATCH] BUG #15126: Fix issues with separated properties/display panels. * The save/restore buttons weren't being hidden properly. * The view wasn't saved as a result the display properties weren't being shown correctly. Change-Id: Id5a1eddff034e53b1fe15d85b69de4e105b4c2ca --- Qt/Components/pqPropertiesPanel.cxx | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/Qt/Components/pqPropertiesPanel.cxx b/Qt/Components/pqPropertiesPanel.cxx index 44841d1..045e935 100644 --- a/Qt/Components/pqPropertiesPanel.cxx +++ b/Qt/Components/pqPropertiesPanel.cxx @@ -371,10 +371,17 @@ void pqPropertiesPanel::setPanelMode(int val) this->Internals->Ui.Delete->setVisible(has_source); this->Internals->Ui.Help->setVisible(has_source); this->Internals->Ui.Reset->setVisible(has_source); + this->Internals->Ui.PropertiesSaveAsDefaults->setVisible(has_source); + this->Internals->Ui.PropertiesRestoreDefaults->setVisible(has_source); this->Internals->Ui.PropertiesFrame->setVisible(has_source); this->Internals->Ui.ViewFrame->setVisible(has_view); + this->Internals->Ui.ViewSaveAsDefaults->setVisible(has_view); + this->Internals->Ui.ViewRestoreDefaults->setVisible(has_view); + this->Internals->Ui.DisplayFrame->setVisible(has_display); + this->Internals->Ui.DisplaySaveAsDefaults->setVisible(has_display); + this->Internals->Ui.DisplayRestoreDefaults->setVisible(has_display); // the buttons need not be shown if there's only 1 type in the panel. bool has_multiples_types = @@ -593,14 +600,15 @@ void pqPropertiesPanel::updateDisplayPanel(pqDataRepresentation* repr) } //----------------------------------------------------------------------------- -void pqPropertiesPanel::updateViewPanel (pqView* _view) +void pqPropertiesPanel::updateViewPanel (pqView* argView) { + pqView* _view = argView; if ( (this->PanelMode & pqPropertiesPanel::VIEW_PROPERTIES) == 0) { _view = NULL; } - if (this->Internals->View != _view) + if (this->Internals->View != argView) { // The view has changed. if (this->Internals->View) @@ -611,8 +619,8 @@ void pqPropertiesPanel::updateViewPanel (pqView* _view) delete this->Internals->ViewWidgets; } } - this->Internals->View = _view; - emit this->viewChanged(_view); + this->Internals->View = argView; + emit this->viewChanged(argView); if (_view) { // create the widgets for this view -- 1.9.1
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/paraview
