Cory, Thanks. I will seriously consider your suggestion on submitting patches.
Regards, Bertwim On 10/11/2014 03:48 PM, Cory Quammen wrote: > Bertwin, > > Great, thanks for letting us know. We'll get the patch in master > probably in the next week or so. > > By the way, if you have the time and interest in contributing patches > to ParaView using our development workflow, this page provides > instructions for how to do it: > > http://www.paraview.org/Wiki/ParaView/Git/Develop > > Thanks, > Cory > > On Fri, Oct 10, 2014 at 10:37 PM, B.W.H. van Beest <[email protected]> wrote: >> Cory: >> >> I did as you explained. The fixes work: >> After 'make clean' in the examples directory and 'make all'; >> >> Tools -> Manage Plugins -> load libRepresentation.so >> 1. The representation plugin works correctly (After loading e.g. Box >> source, gives the representation "Special Mapper") >> >> Tools -> Manage Plugins -> load libHiddenLinesRemoval.so >> 2. The HiddenLinesRemoval plugin works correctly as well. (After loading >> e.g. Box source, gives the representation "Visible Wireframe", which >> works as expected) >> >> Regards, >> Bertwim >> >> >> On 10/11/2014 03:07 AM, Cory Quammen wrote: >>> Hi Bertwin, >>> >>> No problem. It would be helpful to me, though, if you could checkout >>> the change, try it out, and report back on the list if it works for >>> you. >>> >>> To get the change, you will need to have obtained the source via git. >>> If this is the case, go to your ParaView source directory and enter >>> >>> git fetch http://review.source.kitware.com/p/ParaView refs/topics/37/4837/1 >>> git checkout FETCH_HEAD -b 15044_update_example_plugins >>> >>> This will download my topic branch and check it out in your local >>> repository. Compile it again and test. >>> >>> Thanks, >>> Cory >>> >>> On Fri, Oct 10, 2014 at 3:36 PM, B.W.H. van Beest <[email protected]> wrote: >>>> Hi Cory, >>>> >>>> Thanks for putting the fix in. Though willing to contribute, I have no >>>> experience with gerrit. So I don't know what to do, really. >>>> >>>> Regards, >>>> Bertwim >>>> >>>> >>>> On 10/10/2014 08:47 PM, Cory Quammen wrote: >>>>> Hi Bertwim, >>>>> >>>>> Thanks for reporting this bug and proposing a fix. >>>>> >>>>> I posted your report as a bug in the bug tracker: >>>>> >>>>> http://www.paraview.org/Bug/view.php?id=15044 >>>>> >>>>> I also pushed a git topic to gerrit with your fix and some fixes for >>>>> the HiddenLinesRemoval plugin. Please feel free to review it: >>>>> >>>>> http://review.source.kitware.com/#/t/4837/ >>>>> >>>>> Thanks, >>>>> Cory >>>>> >>>>> On Fri, Oct 10, 2014 at 1:53 PM, B.W.H. van Beest <[email protected]> wrote: >>>>>> Could perhaps somebody of Kitware react to this posting of a bug? >>>>>> I noticed a similar issue with the Example plugin "HiddenLinesRemoval", >>>>>> although in that case there seems to be more wrong. >>>>>> >>>>>> Regards, >>>>>> Bertwim >>>>>> >>>>>> >>>>>> On 10/07/2014 10:30 PM, B.W.H. van Beest wrote: >>>>>>> Hello, >>>>>>> >>>>>>> I think there is a bug in the plugin example in >>>>>>> ../ParaView/Examples/Plugin/Representation (Paraview 4.2) >>>>>>> >>>>>>> As given, loading the plugin manually, and then creating a new source >>>>>>> (e.g. Box) causes Paraview to crash with the error message: >>>>>>> >>>>>>>> ERROR: In >>>>>>>> /usr/local/git/ParaView/ParaViewCore/ServerImplementation/Core/vtkSIProxyDefinitionManager.cxx, >>>>>>>> line 565 >>>>>>>> vtkSIProxyDefinitionManager (0x265ebb0): No proxy that matches: >>>>>>>> group=representations and proxy=SurfaceRepresentationBase were found. >>>>>>>> >>>>>>>> >>>>>>>> ERROR: In >>>>>>>> /usr/local/git/ParaView/ParaViewCore/ServerImplementation/Core/vtkSIProxyDefinitionManager.cxx, >>>>>>>> line 989 >>>>>>>> vtkSIProxyDefinitionManager (0x265ebb0): Failed to locate base proxy >>>>>>>> definition (representations, SurfaceRepresentationBase). Aborting for >>>>>>>> debugging purposes. >>>>>>>> >>>>>>>> >>>>>>>> Abort >>>>>>> The error seems to be in the file Representation.xml, where the >>>>>>> attribute >>>>>>> base_proxyname is set to "SurfaceRepresentationBase", which should be >>>>>>> "SurfaceRepresentation" according to the documentation in >>>>>>> http://www.paraview.org/Wiki/ParaView/Plugin_HowTo#Adding_new_Representations_for_3D_View_using_Plugins_.2A_new_in_version_3.7 >>>>>>> >>>>>>> When I make the change, recompile the plugin and load in into Paraview, >>>>>>> there is no longer the above crash when I create a new Box, and the >>>>>>> representation "Special Mapper" feautures in the Representationnn >>>>>>> combobox. >>>>>>> >>>>>>>> [243] Representation> diff Representation.xml.org Representation.xml >>>>>>>> 7c7 >>>>>>>> < base_proxyname="SurfaceRepresentationBase"> >>>>>>>> --- >>>>>>>>> base_proxyname="SurfaceRepresentation"> >>>>>>> Kind Regards, >>>>>>> Bertwim >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Powered by www.kitware.com >>>>>>> >>>>>>> Visit other Kitware open-source projects at >>>>>>> http://www.kitware.com/opensource/opensource.html >>>>>>> >>>>>>> Please keep messages on-topic and check the ParaView Wiki at: >>>>>>> http://paraview.org/Wiki/ParaView >>>>>>> >>>>>>> Follow this link to subscribe/unsubscribe: >>>>>>> http://public.kitware.com/mailman/listinfo/paraview >>>>>>> >>>>>>> >>>>>> _______________________________________________ >>>>>> Powered by www.kitware.com >>>>>> >>>>>> Visit other Kitware open-source projects at >>>>>> http://www.kitware.com/opensource/opensource.html >>>>>> >>>>>> Please keep messages on-topic and check the ParaView Wiki at: >>>>>> http://paraview.org/Wiki/ParaView >>>>>> >>>>>> Follow this link to subscribe/unsubscribe: >>>>>> http://public.kitware.com/mailman/listinfo/paraview > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/paraview
