https://bugzilla.redhat.com/show_bug.cgi?id=2435631

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #3 from Fabio Valentini <[email protected]> ---
This contains a bunch of "test assets" and benchmarking results / data under
assets/ that need closer inspection.

It looks like some of the files under assets/ are also read by tests, but at
the very least, they shouldn't be included in built packages.

The files look OK at first glance. They appear to have been generated by hand
for the purpose of being test input data in this project, and don't contain
objectionable content - but please double-check that.

Maybe it might make sense to exclude assets from published crates that are only
related to benchmarks? Some of the images appear to be referenced from the
README, but most "assets" and the CSV / R file(s) appear to be only read by
benchmarks (which are excluded from the published crate already), and not by
tests.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2435631

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202435631%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to