https://bugzilla.redhat.com/show_bug.cgi?id=2435617
John Eckersberg <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |) --- Comment #2 from John Eckersberg <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - (Blocker) Must provide `bundled(crate(xxx))` for each dependency. Looks like this is handled by %cargo_vendor_manifest described here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_using_vendor_tarballs bootc currently does this and looks correct so should be easy to just copy from there. - (Non-blocker) We should probably have at least a basic manpage. For reference bootc generates most of that from clap but it's somewhat involved and I don't think it's worth holding the review up over it. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License", "*No copyright* GNU General Public License, Version 3", "BSD 0-Clause License", "*No copyright* The Unlicense", "MIT License", "Apache License 2.0 and/or MIT License", "zlib License", "*No copyright* Apache License (v2.0) or MIT license", "Apache License 2.0", "GNU Lesser General Public License, Version 2.1", "Unicode License Agreement - Data Files and Software (2016)", "Apache License (v2.0) or MIT license", "Apache License (v2.0) or MIT license and/or MIT License", "*No copyright* zlib License", "*No copyright* GNU General Public License, Version 2", "*No copyright* Boost Software License 1.0". 5033 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/chunkah/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Reviewer note covering this and previous item: The spec correctly lists chunkah itself as licensed MIT OR Apache-2.0. The list of licenses included via the dependencies is generated at build-time via `cargo license` and packaged as LICENSE.dependencies. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9495 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). Reviewer note: Ok minus the `bundled` thing noted previously. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: chunkah-0.1.1-1.fc44.x86_64.rpm chunkah-0.1.1-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5en0epn6')] checks: 32, packages: 2 chunkah.src: E: spelling-error ('rootfs', "%description -l en_US rootfs -> roots, roofs, root's") chunkah.src: E: spelling-error ("ostree's", "%description -l en_US ostree's -> shoetree's, street's, store's") chunkah.src: E: spelling-error ('oci', '%description -l en_US oci -> oi, loci, sci') chunkah.x86_64: E: spelling-error ('rootfs', "%description -l en_US rootfs -> roots, roofs, root's") chunkah.x86_64: E: spelling-error ("ostree's", "%description -l en_US ostree's -> shoetree's, street's, store's") chunkah.x86_64: E: spelling-error ('oci', '%description -l en_US oci -> oi, loci, sci') chunkah.x86_64: W: no-manual-page-for-binary chunkah 2 packages and 0 specfiles checked; 6 errors, 1 warnings, 7 filtered, 6 badness; has taken 0.7 s Rpmlint (debuginfo) ------------------- Checking: chunkah-debuginfo-0.1.1-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp21km_369')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "chunkah". (none): E: there is no installed rpm "chunkah-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/jlebon/chunkah/releases/download/v0.1.1/chunkah-0.1.1.tar.gz : CHECKSUM(SHA256) this package : d3f8482610f0ae346adfc7835b05c4ab953224d72a8323dc489e70d1d414f888 CHECKSUM(SHA256) upstream package : d3f8482610f0ae346adfc7835b05c4ab953224d72a8323dc489e70d1d414f888 https://github.com/jlebon/chunkah/releases/download/v0.1.1/chunkah-0.1.1-vendor.tar.gz : CHECKSUM(SHA256) this package : 0fde3ee6d2e0da8c0cf99d5941bd93dd0df19197448d8ffb7680db9f6a69ce1b CHECKSUM(SHA256) upstream package : 0fde3ee6d2e0da8c0cf99d5941bd93dd0df19197448d8ffb7680db9f6a69ce1b Requires -------- chunkah (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- chunkah: chunkah chunkah(x86-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name chunkah --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: PHP, Ocaml, R, Perl, SugarActivity, Java, fonts, Python, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2435617 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202435617%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
