https://bugzilla.redhat.com/show_bug.cgi?id=2435698
--- Comment #6 from Ankur Sinha (FranciscoD) <[email protected]> --- Thanks for the review, and the upstream ticket Benson. Comments: a) Reported failing test upstream: https://github.com/jim-easterbrook/python-exiv2/issues/57 ^ noted in spec b) Why require: BuildRequires: libgexiv2-devel instead of: BuildRequires: exiv2-devel ^ not sure why I did that, updated c) Consider packaging the examples as documentation ^ upstream includes examples as a package already, so I'm leaving them in there: /usr/lib64/python3.14/site-packages/exiv2/examples /usr/lib64/python3.14/site-packages/exiv2/examples/README.rst /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__ /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/addmoddel.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/addmoddel.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/easyaccess.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/easyaccess.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifcomment.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifcomment.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifdata.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifdata.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifprint.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifprint.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifvalue.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/exifvalue.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/iptceasy.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/iptceasy.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/thumbnail.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/thumbnail.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/values.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/values.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/xmpsample.cpython-314.opt-1.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/__pycache__/xmpsample.cpython-314.pyc /usr/lib64/python3.14/site-packages/exiv2/examples/addmoddel.py /usr/lib64/python3.14/site-packages/exiv2/examples/easyaccess.py /usr/lib64/python3.14/site-packages/exiv2/examples/exifcomment.py /usr/lib64/python3.14/site-packages/exiv2/examples/exifdata.py /usr/lib64/python3.14/site-packages/exiv2/examples/exifprint.py /usr/lib64/python3.14/site-packages/exiv2/examples/exifvalue.py /usr/lib64/python3.14/site-packages/exiv2/examples/iptceasy.py /usr/lib64/python3.14/site-packages/exiv2/examples/thumbnail.py /usr/lib64/python3.14/site-packages/exiv2/examples/values.py /usr/lib64/python3.14/site-packages/exiv2/examples/xmpsample.py d) Documentation seems to require a number of additional packages not in Fedora. Would be nice to have, be not a must. ^ yeh, I don't include sphinx etc. generated docs in Python packages any more. We're supposed to check the licenses of the included JS and so on, and it's quite a faff. Ben (music) has a bug somewhere where he's explained this in detail. e) Approved. Please fix (b) before import or explain why it should not be fixed. ^ thank you, updated spec/srpm are here, I'll go request a new SCM now. Spec URL: https://ankursinha.fedorapeople.org/python-exiv2/python-exiv2.spec SRPM URL: https://ankursinha.fedorapeople.org/python-exiv2/python-exiv2-0.18.0-4.fc44.src.rpm f) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2435969 would be appreciated if time allows. ^ Running this through Fedora review now. Cheers, -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2435698 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202435698%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
