https://bugzilla.redhat.com/show_bug.cgi?id=2374723
--- Comment #16 from Benson Muite <[email protected]> --- Recreated patch. > Issues: > ======= > 1. systemd_user_post is not invoked in %post and systemd_user_preun in %preun > for Systemd user units service files. > Note: Systemd user unit service file(s) in mpd > See: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units > -> please add the missing macro calls. Done > 2. Directories without known owners: /etc/logrotate.d > -> add %dir /etc/logrotate.d to %files > mpd.x86_64: E: missing-dependency-to-logrotate for logrotate script > /etc/logrotate.d/mpd > -> add a dependency on logrotate (Recommends: if not strictly required) Added dependency on logrotate > 3. [!]: Package consistently uses macros (instead of hard-coded directory > names). > > %{_prefix}/lib/tmpfiles.d/mpd.conf > -> use %{_tmpfilesdir} > > %{_datadir}/icons/hicolor/scalable/apps/mpd.svg > -> use %{_iconsdir} Done > 4. # Allow for privilege escalation when using systemd > Patch1: mpd-0.24-remove_NoNewPrivileges.patch > -> Why do you want to allow that? Remove patch > 5. [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source2: https://pgp.key- > server.io/download/0x236E8A58C6DB4512#/gpgkey.asc > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/SourceURL/ > Looks like key-server.io has expired and was bought by domain flippers. > -> remove the URL Updated URL to MIT pgp keyserver > 6. [!]: Latest version is packaged. > -> Looks like 0.24.5 is out. Updated to 0.24.8 [fedora-review-service-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2374723 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202374723%23c16 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
