https://bugzilla.redhat.com/show_bug.cgi?id=2431992
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(decathorpe@gmail. | |com) | --- Comment #5 from Fabio Valentini <[email protected]> --- I am at CentOS Connect / FOSDEM, I will probably only have time to look at this more next week. Just a few quick comments: 1. This should not be necessary (or actually be superfluous / unused) when not using vendored dependencies: > BuildRequires: openssl-devel > # Use system OpenSSL instead of building from source > export OPENSSL_NO_VENDOR=1 2. The patches are not documented (or at least not in the spec file, which they should be). Also, if any of them are upstreamable, that should happen and links to the upstream PRs or commits should be added. 3. The License tag looks very big and contains duplicates - it doesn't exactly look *wrong* but it's also messy. For example, you don't need to have both (Apache-2.0 OR MIT) *and* (MIT OR Apache-2.0), they're equivalent. You could drop one of them (I usually keep the one that sorts first alphabetically). Also, Things like "((Apache-2.0 OR MIT) AND BSD-3-Clause) AND ..." can be flattened (AND is associative and the order doesn't matter), so those are two more duplicates you can avoid. You can also use syntax like this to avoid the very long line (and better diff it): License: %{shrink: Apache-2.0 AND MIT AND BSD-3-Clause AND ... } -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2431992 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431992%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
