https://bugzilla.redhat.com/show_bug.cgi?id=2432624
Aleksei Bavshin <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] CC| |[email protected] Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #2 from Aleksei Bavshin <[email protected]> --- The main issue with this package is that it does not quite work in Fedora: - it does not prepare the expected environment for pam_systemd. At least XDG_SESSION_CLASS, XDG_SEAT and XDG_VTNR are required and should be set with pam_putenv before calling pam_open_session. GNOME will also require XDG_SESSION_TYPE. - it is blocked by SELinux. A possible solution is to label lidm as a display manager. This could be done as a policy module[1][2] or in the main policy[3]. [1]: https://fedoraproject.org/wiki/SELinux/IndependentPolicy [2]: https://src.fedoraproject.org/rpms/greetd/blob/rawhide/f/greetd.fc [3]: https://github.com/fedora-selinux/selinux-policy/pull/2977 Some less important issues: - v2.0.0 is available: https://github.com/javalsai/lidm/releases/tag/v2.0.0 - LDFLAGS are not applied: lidm.x86_64: W: position-independent-executable-suggested /usr/bin/lidm Should be already fixed in v2.0.0 Makefile. - Makefile embeds the current date into the executable, resulting in a non-reproducible build: > #define LIDM_BUILD_TS '$$(date +%s) Consider patching it to use $SOURCE_DATE_EPOCH (or passing INFO_BUILD_TS=$SOURCE_DATE_EPOCH to %make_build with v2.0.0). > %forgemeta IMO, the spec is too simple to require forge macros. Not going to block the review on that though. > BuildRequires: pam_yubico > Requires: pam_yubico Nothing in this project depends on or uses pam_yubico. > install -Dm644 themes/cherry.ini > %{buildroot}%{_datadir}/lidm/themes/cherry.ini I'd suggest `install -Dm644 -t %{buildroot}%{_datadir}/lidm/themes themes/*.ini`, unless you have a reason to list the themes explicitly. > %preun > %systemd_preun lidm.service %post scriptlet with %systemd_post is missing. > %{_sysconfdir}/lidm.ini Missing %config(noreplace). > /%{_unitdir}/lidm.service Unnecessary leading slash. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432624 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432624%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
