https://bugzilla.redhat.com/show_bug.cgi?id=2431166



--- Comment #4 from Miro HronĨok <[email protected]> ---
I am distracted. I stated my concerns, but APPROVED the package anyway :D

The concerns that should be addressed upon importing:

- Use %py_provides instead of Provides, so it also provides
python-roman-numerals-py and python3.14-roman-numerals-py (it also removes the
need to specify the version to provide).
- Considering the version difference, please Obsolete < 4~~, so if by any
chance a hotfix 3.1.1 is released (unlikely), and we update to it in Fedora 43,
this Obsoletes does not need to be updated.
- Add a comment above the pytest requirement.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2431166

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431166%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to