https://bugzilla.redhat.com/show_bug.cgi?id=2431271
--- Comment #4 from Fabio Valentini <[email protected]> --- Thank you for the review! > The spec was generated with rust2rpm, simplifying the review. > > Manual modifications cover enabling and properly packaging the CLI tool. > > - The “%global debug_package %{nil}” is removed, since there is a compiled > binary and therefore there should be a usable debuginfo package. > - A “%package -n %{crate}” section is added, with all of the details properly > handled, including corresponding %description and %files; License tag and > surrounding comments; license text files; runtime dependencies; and so on. I used a rust2rpm.toml config file with ``` [features] enable = ["cli"] ``` So these are actually not manual modifications, but just what gets generated for an application package. I do need to fix a bug in rust2rpm related to this code path, though ... > The binary name “ingredients” is slightly generic, but I verified nothing > conflicts with it, and a quick search didn’t turn up any prominent projects > that are likely to conflict with it in the future, so I think this is fine. Thanks for checking that too. I did a fair amount of research to avoid having a name conflict with another project before I settled on "ingredients". :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2431271 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431271%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
