https://bugzilla.redhat.com/show_bug.cgi?id=2428466
Steve Cossette <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Steve Cossette <[email protected]> --- Curious, is there a reason why you started using cmake() BRs and then switched to package names? I think it might be a good idea to reference all of the cmake BRs in the spec for futureproofing (In case the cmake modules get moved around for example). Also, you have cmake(Qt6Core) and qt6-qtbase-devel referenced which are the same thing. kf6-rpm-macros needs to be added as a BR too. While this isn't an official KDE project, you should probably also use %cmake_kf6 instead of %cmake -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2428466 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202428466%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
