https://bugzilla.redhat.com/show_bug.cgi?id=2430592
--- Comment #5 from Michael Katzmann <[email protected]> --- (In reply to Miroslav Suchý from comment #4) > > License: Unknown > > You should identify the license. Please see > https://docs.fedoraproject.org/en-US/legal/license-field/ The scripts are GPL but the firmware hex/binary files are as provided by NI and HP/Keysight for the particular instrument (required for, and only used if you have the hardware). I don't know how other firmware distributions on Linux handle this. > > > udevadm control --reload > /dev/null 2>&1 || : > > Should rather be: > > if [ -S /run/udev/control ]; then > udevadm control --reload > udevadm trigger > fi > OK > > %defattr(644,root,root,755) OK > > This is the default. You can remove this line. > > > shopt -s nullglob > > This is very uncommon. And if I read the code correctly, it is not needed. Yes, it's needed otherwise errors will arrise in the install line. Like the following demonstration: $ for adapter in agilent_82357a hp_82341 hp_82350a ni_gpib_usb_b ; do ls $adapter/{*.bin,*.hex}; done ls: cannot access 'agilent_82357a/*.bin': No such file or directory agilent_82357a/82357a_fw.hex agilent_82357a/measat_releaseX1.8.hex ls: cannot access 'hp_82341/*.hex': No such file or directory hp_82341/hp_82341c_fw.bin hp_82341/hp_82341d_fw.bin ls: cannot access 'hp_82350a/*.hex': No such file or directory hp_82350a/agilent_82350a.bin ls: cannot access 'ni_gpib_usb_b/*.bin': No such file or directory ni_gpib_usb_b/niusbb_firmware.hex ni_gpib_usb_b/niusbb_loader.hex $ $ shopt -s nullglob $ for adapter in agilent_82357a hp_82341 hp_82350a ni_gpib_usb_b ; do ls $adapter/{*.bin,*.hex}; done agilent_82357a/82357a_fw.hex agilent_82357a/measat_releaseX1.8.hex hp_82341/hp_82341c_fw.bin hp_82341/hp_82341d_fw.bin hp_82350a/agilent_82350a.bin ni_gpib_usb_b/niusbb_firmware.hex ni_gpib_usb_b/niusbb_loader.hex $ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2430592 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202430592%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
