https://bugzilla.redhat.com/show_bug.cgi?id=2404638



--- Comment #14 from [email protected] ---
Spec URL: https://trix.fedorapeople.org/python-amd-debug-tools.spec
SRPM URL:
https://trix.fedorapeople.org/python-amd-debug-tools-0.2.12-1.fc44.src.rpm

- Can you build the latest? 0.2.11

Updated to 0.2.12

- I assume you dropped cysystemd because fedora doesn't have a package for it?
Any feature loss or problems doing this? Please note it in a comment.

No loss or problems.

- Shouldn't you exclusive arch this for all arches with amdgpu enabled? I think
that's ppc64le, arm64, and probably riscv. It's noarch, so no risk of build
breakage.

Sure, but I only tested this on x86.
I have no way to know if any of these alt arches work, so that is risk.

- Please notify upstream of the PKG-INFO file if you haven't already and note
in the comment.

I have improved the comment some to this

# PKG-INFO is not a static file, it is generated by building
# python3 -m build
# We use a different build process so we need to manually add the file.
# Do the above command then untar the dist/amd_debug_tools-* to find it.

I do not believe this is a real problem, the upstream generates this file as a
byproduct of their build.

- Please use "cp -p" in %prep

ok


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2404638

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202404638%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to