https://bugzilla.redhat.com/show_bug.cgi?id=2427087
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #16 from Fabio Valentini <[email protected]> --- The latest version looks good to me, with three caveats: a) The "%{_userunitdir}/[email protected]/" directory is unowned. Fixing this should be easy, just add an "%%{_userunitdir}/[email protected]/" entry to the %files list directly above the corresponding ../session.conf files entry. b) One very minor issue that you can fix before importing: It looks like some files (tests/fixtures/*.png) are covered by a CC-BY-SA-4.0 license. This probably should be documented in the spec file (even if they don't contribute to the License tag, because they don't get installed), they technically *do* affect the SourceLicense tag. c) One last thing you could consider changing, which isn't *wrong* per se, so I'll leave it up to you if you want to do this: Running the tests is covered by the "if check" condition, but the dependencies that are only necessary for those tests are not. You could wrap the dbus-daemon, desktop-file-utils, xorg-x11-server-Xvfb, and foot BuildRequires in "%if %{with check}" too. Full review included below. ============== Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ This is a false positive: This is not a C/C++ project. - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in phrog See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units This is a false positive: The user session units are not activatable, so the systemd scriptlets cannot (and should not) be used for them. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/systemd/user/[email protected] [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/user/[email protected] [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in phrog [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2432 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. This is an expected issue when using SRPM files that have already been processed by rpmautospec. [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: phrog-0.50.0-1.fc44.x86_64.rpm phrog-0.50.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ phrog.src: E: spelling-error ('greetd', 'Summary(en_US) greetd -> greets, greet, greed') phrog.src: E: spelling-error ('greetd', '%description -l en_US greetd -> greets, greet, greed') phrog.x86_64: E: spelling-error ('greetd', 'Summary(en_US) greetd -> greets, greet, greed') phrog.x86_64: E: spelling-error ('greetd', '%description -l en_US greetd -> greets, greet, greed') phrog.x86_64: W: no-manual-page-for-binary phrog phrog.spec: W: invalid-url Source1: vendor-0.50.0.tar.gz 2 packages and 0 specfiles checked; 4 errors, 2 warnings, 7 filtered, 4 badness; has taken 0.7 s These are all harmless. Rpmlint (debuginfo) ------------------- Checking: phrog-debuginfo-0.50.0-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ phrog.x86_64: W: unused-direct-shlib-dependency /usr/bin/phrog /lib64/libcairo-gobject.so.2 phrog.x86_64: W: unused-direct-shlib-dependency /usr/bin/phrog /lib64/libpango-1.0.so.0 phrog.x86_64: W: unused-direct-shlib-dependency /usr/bin/phrog /lib64/libcairo.so.2 phrog.x86_64: E: spelling-error ('greetd', 'Summary(en_US) greetd -> greets, greet, greed') phrog.x86_64: E: spelling-error ('greetd', '%description -l en_US greetd -> greets, greet, greed') phrog.x86_64: W: no-manual-page-for-binary phrog 2 packages and 0 specfiles checked; 2 errors, 4 warnings, 9 filtered, 2 badness; has taken 0.3 s These are all harmless. Source checksums ---------------- https://github.com/samcday/phrog/archive/0.50.0/phrog-0.50.0.tar.gz : CHECKSUM(SHA256) this package : b1dfff122fa0faf74e1fdb9ef9d417a9a9d0745e2913287ce2c0a6c0027a946c CHECKSUM(SHA256) upstream package : b1dfff122fa0faf74e1fdb9ef9d417a9a9d0745e2913287ce2c0a6c0027a946c Requires -------- phrog (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash accountsservice config(phrog) gnome-session greetd ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libhandy-1.so.0()(64bit) libhandy-1.so.0(LIBHANDY_1_0)(64bit) libpango-1.0.so.0()(64bit) libphosh-0.45.so.0()(64bit) libphosh-0.45.so.0(LIBPHOSH_0_45_0)(64bit) phoc phosh-osk rtld(GNU_HASH) Provides -------- phrog: application() application(mobi.phosh.Phrog.desktop) bundled(crate(anstream)) bundled(crate(anstyle)) bundled(crate(anstyle-parse)) bundled(crate(anstyle-query)) bundled(crate(anstyle-wincon)) bundled(crate(anyhow)) bundled(crate(async-broadcast)) bundled(crate(async-channel)) bundled(crate(async-executor)) bundled(crate(async-global-executor)) bundled(crate(async-io)) bundled(crate(async-lock)) bundled(crate(async-process)) bundled(crate(async-recursion)) bundled(crate(async-signal)) bundled(crate(async-task)) bundled(crate(async-trait)) bundled(crate(atk)) bundled(crate(atk-sys)) bundled(crate(atomic-waker)) bundled(crate(autocfg)) bundled(crate(bitflags)) bundled(crate(blocking)) bundled(crate(cairo-rs)) bundled(crate(cairo-sys-rs)) bundled(crate(cc)) bundled(crate(cfg-expr)) bundled(crate(cfg-if)) bundled(crate(cfg_aliases)) bundled(crate(clap)) bundled(crate(clap_builder)) bundled(crate(clap_derive)) bundled(crate(clap_lex)) bundled(crate(colorchoice)) bundled(crate(concurrent-queue)) bundled(crate(crossbeam-utils)) bundled(crate(downcast-rs)) bundled(crate(endi)) bundled(crate(enumflags2)) bundled(crate(enumflags2_derive)) bundled(crate(equivalent)) bundled(crate(errno)) bundled(crate(event-listener)) bundled(crate(event-listener-strategy)) bundled(crate(fastrand)) bundled(crate(field-offset)) bundled(crate(find-msvc-tools)) bundled(crate(futures-channel)) bundled(crate(futures-core)) bundled(crate(futures-executor)) bundled(crate(futures-io)) bundled(crate(futures-lite)) bundled(crate(futures-macro)) bundled(crate(futures-task)) bundled(crate(futures-util)) bundled(crate(gdk)) bundled(crate(gdk-pixbuf)) bundled(crate(gdk-pixbuf-sys)) bundled(crate(gdk-sys)) bundled(crate(getrandom)) bundled(crate(gio)) bundled(crate(gio-sys)) bundled(crate(glib)) bundled(crate(glib-build-tools)) bundled(crate(glib-macros)) bundled(crate(glib-sys)) bundled(crate(glob)) bundled(crate(gobject-sys)) bundled(crate(greetd_ipc)) bundled(crate(gtk)) bundled(crate(gtk-sys)) bundled(crate(gtk3-macros)) bundled(crate(hashbrown)) bundled(crate(heck)) bundled(crate(hermit-abi)) bundled(crate(hex)) bundled(crate(indexmap)) bundled(crate(input-event-codes)) bundled(crate(is_terminal_polyfill)) bundled(crate(itoa)) bundled(crate(libc)) bundled(crate(libhandy)) bundled(crate(libhandy-sys)) bundled(crate(libphosh)) bundled(crate(libphosh-sys)) bundled(crate(linux-raw-sys)) bundled(crate(log)) bundled(crate(memchr)) bundled(crate(memoffset)) bundled(crate(nix)) bundled(crate(once_cell)) bundled(crate(once_cell_polyfill)) bundled(crate(ordered-stream)) bundled(crate(pango)) bundled(crate(pango-sys)) bundled(crate(parking)) bundled(crate(pin-project-lite)) bundled(crate(pin-utils)) bundled(crate(piper)) bundled(crate(pkg-config)) bundled(crate(polling)) bundled(crate(proc-macro-crate)) bundled(crate(proc-macro-error)) bundled(crate(proc-macro-error-attr)) bundled(crate(proc-macro2)) bundled(crate(quick-xml)) bundled(crate(quote)) bundled(crate(r-efi)) bundled(crate(rustc_version)) bundled(crate(rustix)) bundled(crate(ryu)) bundled(crate(semver)) bundled(crate(serde)) bundled(crate(serde_core)) bundled(crate(serde_derive)) bundled(crate(serde_json)) bundled(crate(serde_repr)) bundled(crate(serde_spanned)) bundled(crate(shlex)) bundled(crate(signal-hook-registry)) bundled(crate(slab)) bundled(crate(smallvec)) bundled(crate(static_assertions)) bundled(crate(strsim)) bundled(crate(syn)) bundled(crate(system-deps)) bundled(crate(target-lexicon)) bundled(crate(tempfile)) bundled(crate(thiserror)) bundled(crate(thiserror-impl)) bundled(crate(toml)) bundled(crate(toml_datetime)) bundled(crate(toml_edit)) bundled(crate(toml_parser)) bundled(crate(tracing)) bundled(crate(tracing-attributes)) bundled(crate(tracing-core)) bundled(crate(uds_windows)) bundled(crate(unicode-ident)) bundled(crate(utf8parse)) bundled(crate(uuid)) bundled(crate(version-compare)) bundled(crate(version_check)) bundled(crate(wasip2)) bundled(crate(wayland-backend)) bundled(crate(wayland-client)) bundled(crate(wayland-protocols)) bundled(crate(wayland-protocols-misc)) bundled(crate(wayland-protocols-wlr)) bundled(crate(wayland-scanner)) bundled(crate(wayland-sys)) bundled(crate(winapi)) bundled(crate(winapi-i686-pc-windows-gnu)) bundled(crate(winapi-x86_64-pc-windows-gnu)) bundled(crate(windows-link)) bundled(crate(windows-sys)) bundled(crate(winnow)) bundled(crate(wit-bindgen)) bundled(crate(zbus)) bundled(crate(zbus_macros)) bundled(crate(zbus_names)) bundled(crate(zvariant)) bundled(crate(zvariant_derive)) bundled(crate(zvariant_utils)) config(phrog) phrog phrog(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/deca/Workspace/package-reviews/2427087-phrog/srpm/phrog.spec 2026-01-16 22:21:59.675734833 +0100 +++ /home/deca/Workspace/package-reviews/2427087-phrog/srpm-unpacked/phrog.spec 2026-01-14 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %bcond check 1 @@ -126,3 +136,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jan 14 2026 Sam Day <[email protected]> - 0.50.0-1 +- initial commit - 0.50.0 +## END: Generated by rpmautospec ================================================================================ Package APPROVED. Please address point a) and b) before importing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2427087 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202427087%23c16 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
