https://bugzilla.redhat.com/show_bug.cgi?id=2429568
Priscila Gutierres <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Priscila Gutierres <[email protected]> --- MUST ITEMS - GENERIC ================================================================================ [X] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines [X] License field in the package spec file matches the actual license [X] License text included in package (LICENSE file) [X] Spec file is legible and written in American English [X] Spec file name matches the base package %{name} [X] Package successfully compiles and builds into binary RPMs on at least one primary architecture [X] BuildRequires list all build dependencies [X] Requires list all runtime dependencies (auto-generated via %pyproject_save_files) [X] Package contains no bundled libraries without FPC exception [X] Changelog in prescribed format [X] Package consistently uses macros [X] Package contains code, or permissible content [X] Large documentation files go in -doc subpackage (N/A - small package) [X] Packages must not own files or directories already owned by other packages [X] All filenames are valid UTF-8 [X] Macros used instead of hard-coded paths MUST ITEMS - PYTHON SPECIFIC ================================================================================ [X] Package follows Python Packaging Guidelines [X] Uses %pyproject_* macros (wheel, install, save_files) [X] Uses %pyproject_buildrequires for automatic dependency generation [X] Binary package name follows python3-%{name} pattern [X] BuildArch: noarch is set (pure Python package) [X] %py3_shebang_fix used if needed (N/A if no scripts) [X] Uses %{python3_sitelib} or %{python3_sitearch} appropriately [X] %pyproject_save_files preserves license (-l flag used) SHOULD ITEMS - GENERIC ================================================================================ [X] Reviewer tests package builds in mock [X] Package builds in koji [X] Rpmlint output reviewed and addressed [X] Package follows Packaging Guidelines [X] Package contains man pages (N/A - no man pages) [X] Uses %autorelease and %autochangelog SHOULD ITEMS - PYTHON SPECIFIC ================================================================================ [X] Latest version packaged [X] Package uses PyPI as Source0 [X] %check section includes tests [X] Tests pass successfully [X] Documentation included in %doc SPECIFIC CHECKS FOR PYTHON-RICH-RST ================================================================================ SOURCE VERIFICATION -------------------------------------------------------------------------------- [X] Source tarball downloads correctly from PyPI [X] Source tarball contains expected files (rich_rst/ directory) [X] Version in spec matches PyPI version (1.3.2) [X] Source uses correct name format (rich_rst with underscore, not rich-rst) BUILDREQUIRES REVIEW -------------------------------------------------------------------------------- [X] python3-devel included [X] python3-pytest explicitly listed (required - not in pyproject.toml) DEPENDENCIES -------------------------------------------------------------------------------- [X] Runtime dependencies auto-detected correctly: [X] No manual Requires needed TESTS -------------------------------------------------------------------------------- [X] Verified test files exist in source tarball: Command: tar -tzf rich_rst-1.3.2.tar.gz | grep -E "test.*\.py$" FILES SECTION -------------------------------------------------------------------------------- [X] %{pyproject_files} includes all installed files [X] LICENSE handled by -l flag in %pyproject_save_files [X] README.md included as %doc [X] No files listed manually that are in %{pyproject_files} LICENSE VERIFICATION -------------------------------------------------------------------------------- [X] LICENSE file contains MIT license text [X] Source files contain license headers or reference [X] License matches upstream declaration BUILD TESTING ================================================================================ LOCAL BUILD -------------------------------------------------------------------------------- Results: [X] Mock build successful [X] No rpmlint errors (warnings acceptable if justified) [X] RPM installs correctly KOJI BUILD -------------------------------------------------------------------------------- [X] Scratch build successful [X] All architectures build (noarch should be universal) Koji scratch build URL: https://copr.fedorainfracloud.org/coprs/samdoran/python-rich-rst/build/10009878/ FINAL CHECKS ================================================================================ [X] Package name appropriate and follows guidelines [X] Summary is concise and descriptive [X] Description provides useful information [X] URL points to correct upstream [X] All sections present and properly formatted [X] No obvious security concerns [X] Upstream active and maintained -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2429568 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202429568%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
