https://bugzilla.redhat.com/show_bug.cgi?id=2428633



--- Comment #3 from Mikel Olasagasti Uranga <[email protected]> ---

>> %autopatch -p1
> You do not have any patches. So you do not need it.

go2rpm template adds that by default. The idea, iirc, was to have it by default
but I can remove it.

>> ExcludeArch:    %{ix86} ppc64le s390x

> Any reason for this? If there is valid reason you should have comment above 
> linking to BZ. See 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures
Maybe you wanted to use ExclusiveArch - see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_go_language_architectures

Original package had it so I kept it. "%{ix86}" could be removed as with
"%gometa -f" it already ignores that arch.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2428633

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202428633%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to