https://bugzilla.redhat.com/show_bug.cgi?id=2399600
Fedor Vorobev <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] QA Contact|[email protected] |[email protected] Flags| |fedora-review? | |needinfo?(solomoncyj@gmail. | |com) --- Comment #8 from Fedor Vorobev <[email protected]> --- A couple of questions/remarks: - If only headers are packaged and tests are disabled, what does CMake even do there? Just installs the files? - Why depend on `pkgconfig(lua)` and not `lua-devel`? CMake uses its own find_package() scripts to find Lua and not pkgconfig. - Consider building and packaging the API documentation included in the sources. Other than that looks fine to me. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
