https://bugzilla.redhat.com/show_bug.cgi?id=2426334
--- Comment #2 from Ben Beasley <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. I noted several adjustments from the default output, which I presume you are tracking in rust2rpm.toml. Overly-strict dependencies on crc, indexmap, and proptest are loosened. These are all reasonable, adequately-documented, and reasonable to keep downstream-only. You might note in the comment that all three of these upstream version pins are solely for MSRV reasons. Removing dev-dependencies on criterion (benchmark-only) and wasm-bindgen-test (WASM-only) is also a reasonable downstream adjustment. Installation of executables is disabled. Looking at https://crates.io/crates/crc-fast, this is probably the right thing to do, because the “checksum” tool is too generically-named, and “get-custom-params” and “arch-check” are probably not useful to install system-wide (and are still very generically-named). Two tests are skipped, and this is well-documented and reasonable. The crate supports building a C-ABI shared library. You might be asked to supply this at some point, if something starts to depend it. You can consult the rust-libcramjam and rust-rustc-demangle-capi packages for examples of how this can be done. For now, the choice to package only the Rust crate library is reasonable. Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Spurious: if a C/C++ compiler is required, then the dependency will be satisfied through the cc crate. - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/crc- fast-1.9.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to a reasonable rust2rpm design decision - The file src/combine.rs contains Zlib-licensed code, which is not reflected in the license metadata. Please update the license expression from "MIT OR Apache-2.0" to "(MIT OR Apache-2.0) AND Zlib" using rust2rpm -p, and reference https://github.com/awesomized/crc-fast-rust/pull/41. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "zlib License". 45 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2426334-rust-crc- fast/licensecheck.txt Some code in src/combine.rs is Zlib-licensed; see Issues. [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As noted in https://github.com/awesomized/crc-fast-rust/pull/41, one could ask for the Zlib license text to be in a separate file, but it’s not as important since the Zlib license doesn’t require text to be included in binary distributions, and the license text is in the source code. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- crc-fast-devel , rust-crc-fast+default-devel , rust-crc-fast+alloc- devel , rust-crc-fast+cache-devel , rust-crc-fast+cli-devel , rust- crc-fast+digest-devel , rust-crc-fast+ffi-devel , rust-crc- fast+hashbrown-devel , rust-crc-fast+indexmap-devel , rust-crc- fast+optimize_crc32_auto-devel , rust-crc- fast+optimize_crc32_avx512_v4s3x3-devel , rust-crc- fast+optimize_crc32_avx512_vpclmulqdq_v3x2-devel , rust-crc- fast+optimize_crc32_neon_blended-devel , rust-crc- fast+optimize_crc32_neon_eor3_v9s3x2e_s3-devel , rust-crc- fast+optimize_crc32_neon_v12e_v1-devel , rust-crc- fast+optimize_crc32_neon_v3s4x2e_v2-devel , rust-crc- fast+optimize_crc32_sse_v4s3x3-devel , rust-crc-fast+panic-handler- devel , rust-crc-fast+spin-devel , rust-crc-fast+std-devel , rust-crc- fast+vpclmulqdq-devel [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=140546780 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: differences are solely due to rpmautospec macro expansion. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-crc-fast-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+default-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+alloc-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+cache-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+cli-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+digest-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+ffi-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+hashbrown-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+indexmap-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_auto-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_avx512_v4s3x3-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_avx512_vpclmulqdq_v3x2-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_neon_blended-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_neon_eor3_v9s3x2e_s3-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_neon_v12e_v1-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_neon_v3s4x2e_v2-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+optimize_crc32_sse_v4s3x3-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+panic-handler-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+spin-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+std-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast+vpclmulqdq-devel-1.9.0-1.fc44.noarch.rpm rust-crc-fast-1.9.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe7xxdav1')] checks: 32, packages: 22 22 packages and 0 specfiles checked; 0 errors, 0 warnings, 127 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 21 21 packages and 0 specfiles checked; 0 errors, 0 warnings, 123 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/crc-fast/1.9.0/download#/crc-fast-1.9.0.crate : CHECKSUM(SHA256) this package : 2fd92aca2c6001b1bf5ba0ff84ee74ec8501b52bbef0cac80bf25a6c1d87a83d CHECKSUM(SHA256) upstream package : 2fd92aca2c6001b1bf5ba0ff84ee74ec8501b52bbef0cac80bf25a6c1d87a83d Requires -------- rust-crc-fast-devel (rpmlib, GLIBC filtered): (crate(crc/default) >= 3.3.0 with crate(crc/default) < 4.0.0~) (crate(rustversion/default) >= 1.0.0 with crate(rustversion/default) < 2.0.0~) (crate(spin) >= 0.10.0 with crate(spin) < 0.11.0~) (crate(spin/mutex) >= 0.10.0 with crate(spin/mutex) < 0.11.0~) (crate(spin/once) >= 0.10.0 with crate(spin/once) < 0.11.0~) (crate(spin/rwlock) >= 0.10.0 with crate(spin/rwlock) < 0.11.0~) (crate(spin/spin_mutex) >= 0.10.0 with crate(spin/spin_mutex) < 0.11.0~) cargo rust rust-crc-fast+default-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) crate(crc-fast/ffi) crate(crc-fast/panic-handler) crate(crc-fast/std) rust-crc-fast+alloc-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) crate(crc-fast/digest) rust-crc-fast+cache-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) crate(crc-fast/alloc) crate(crc-fast/hashbrown) crate(crc-fast/spin) rust-crc-fast+cli-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) crate(crc-fast/std) rust-crc-fast+digest-devel (rpmlib, GLIBC filtered): (crate(digest) >= 0.10.0 with crate(digest) < 0.11.0~) (crate(digest/alloc) >= 0.10.0 with crate(digest/alloc) < 0.11.0~) cargo crate(crc-fast) rust-crc-fast+ffi-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+hashbrown-devel (rpmlib, GLIBC filtered): (crate(hashbrown/default) >= 0.16.0 with crate(hashbrown/default) < 0.17.0~) cargo crate(crc-fast) rust-crc-fast+indexmap-devel (rpmlib, GLIBC filtered): (crate(indexmap/default) >= 2.11.0 with crate(indexmap/default) < 3.0.0~) cargo crate(crc-fast) rust-crc-fast+optimize_crc32_auto-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+optimize_crc32_avx512_v4s3x3-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+optimize_crc32_avx512_vpclmulqdq_v3x2-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+optimize_crc32_neon_blended-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+optimize_crc32_neon_eor3_v9s3x2e_s3-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+optimize_crc32_neon_v12e_v1-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+optimize_crc32_neon_v3s4x2e_v2-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+optimize_crc32_sse_v4s3x3-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+panic-handler-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) rust-crc-fast+spin-devel (rpmlib, GLIBC filtered): (crate(spin) >= 0.10.0 with crate(spin) < 0.11.0~) (crate(spin/mutex) >= 0.10.0 with crate(spin/mutex) < 0.11.0~) (crate(spin/once) >= 0.10.0 with crate(spin/once) < 0.11.0~) (crate(spin/rwlock) >= 0.10.0 with crate(spin/rwlock) < 0.11.0~) (crate(spin/spin_mutex) >= 0.10.0 with crate(spin/spin_mutex) < 0.11.0~) cargo crate(crc-fast) rust-crc-fast+std-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) crate(crc-fast/alloc) rust-crc-fast+vpclmulqdq-devel (rpmlib, GLIBC filtered): cargo crate(crc-fast) Provides -------- rust-crc-fast-devel: crate(crc-fast) rust-crc-fast-devel rust-crc-fast+default-devel: crate(crc-fast/default) rust-crc-fast+default-devel rust-crc-fast+alloc-devel: crate(crc-fast/alloc) rust-crc-fast+alloc-devel rust-crc-fast+cache-devel: crate(crc-fast/cache) rust-crc-fast+cache-devel rust-crc-fast+cli-devel: crate(crc-fast/cli) rust-crc-fast+cli-devel rust-crc-fast+digest-devel: crate(crc-fast/digest) rust-crc-fast+digest-devel rust-crc-fast+ffi-devel: crate(crc-fast/ffi) rust-crc-fast+ffi-devel rust-crc-fast+hashbrown-devel: crate(crc-fast/hashbrown) rust-crc-fast+hashbrown-devel rust-crc-fast+indexmap-devel: crate(crc-fast/indexmap) rust-crc-fast+indexmap-devel rust-crc-fast+optimize_crc32_auto-devel: crate(crc-fast/optimize_crc32_auto) rust-crc-fast+optimize_crc32_auto-devel rust-crc-fast+optimize_crc32_avx512_v4s3x3-devel: crate(crc-fast/optimize_crc32_avx512_v4s3x3) rust-crc-fast+optimize_crc32_avx512_v4s3x3-devel rust-crc-fast+optimize_crc32_avx512_vpclmulqdq_v3x2-devel: crate(crc-fast/optimize_crc32_avx512_vpclmulqdq_v3x2) rust-crc-fast+optimize_crc32_avx512_vpclmulqdq_v3x2-devel rust-crc-fast+optimize_crc32_neon_blended-devel: crate(crc-fast/optimize_crc32_neon_blended) rust-crc-fast+optimize_crc32_neon_blended-devel rust-crc-fast+optimize_crc32_neon_eor3_v9s3x2e_s3-devel: crate(crc-fast/optimize_crc32_neon_eor3_v9s3x2e_s3) rust-crc-fast+optimize_crc32_neon_eor3_v9s3x2e_s3-devel rust-crc-fast+optimize_crc32_neon_v12e_v1-devel: crate(crc-fast/optimize_crc32_neon_v12e_v1) rust-crc-fast+optimize_crc32_neon_v12e_v1-devel rust-crc-fast+optimize_crc32_neon_v3s4x2e_v2-devel: crate(crc-fast/optimize_crc32_neon_v3s4x2e_v2) rust-crc-fast+optimize_crc32_neon_v3s4x2e_v2-devel rust-crc-fast+optimize_crc32_sse_v4s3x3-devel: crate(crc-fast/optimize_crc32_sse_v4s3x3) rust-crc-fast+optimize_crc32_sse_v4s3x3-devel rust-crc-fast+panic-handler-devel: crate(crc-fast/panic-handler) rust-crc-fast+panic-handler-devel rust-crc-fast+spin-devel: crate(crc-fast/spin) rust-crc-fast+spin-devel rust-crc-fast+std-devel: crate(crc-fast/std) rust-crc-fast+std-devel rust-crc-fast+vpclmulqdq-devel: crate(crc-fast/vpclmulqdq) rust-crc-fast+vpclmulqdq-devel Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2426334-rust-crc-fast/srpm/rust-crc-fast.spec 2025-12-31 12:47:07.285262582 +0000 +++ /home/ben/fedora/review/2426334-rust-crc-fast/srpm-unpacked/rust-crc-fast.spec 2025-12-30 00:00:00.000000000 +0000 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 28 %bcond check 1 @@ -311,3 +321,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Tue Dec 30 2025 John Doe <[email protected]> - 1.9.0-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2426334 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Perl, R, Ocaml, PHP, Haskell, Python, SugarActivity, fonts, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2426334 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202426334%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
