https://bugzilla.redhat.com/show_bug.cgi?id=2425596
--- Comment #2 from Christoph Erhardt <[email protected]> --- Thank you for the fast review! I have updated the published files. Spec URL: https://www4.cs.fau.de/~erhardt/fedora-review/katarakt.spec SRPM URL: https://www4.cs.fau.de/~erhardt/fedora-review/katarakt-0.3-1.fc44.src.rpm a) Looks good to me. b) Done as suggested. c) Unfortunately, `./katarakt --version` and `./katarakt --help` do not work on a headless system. This might be because the `QApplication` object gets initialised at the top of `main()`. I'll see if I can work with upstream to fix this. d) Desktop file and AppStream metainfo added as suggested. Since upstream does not provide an application icon, I have picked the generic `application-pdf` icon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2425596 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202425596%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
