https://bugzilla.redhat.com/show_bug.cgi?id=2423802
--- Comment #5 from Ben Beasley <[email protected]> --- Thank you for the review! (In reply to Fabio Valentini from comment #4) > Package looks good to me, with a few minor things that I trust you can > address before importing: > > - Exclude the scripts/ folder from the package. It causes a dependency on > /bin/bash. Good catch. I always try to check for this, but occasionally forget. > - Maybe also exclude the tests/files folder. It contains only test input > files. Hmm. On the one hand, the tests still pass if I do this. On the other hand, the tests tests/compile-fail/*.rs are running in the package build, and their sources indicate they should rely on these files, so perhaps removing these files is undermining these tests by making compilation fail for the wrong reason? I think that rather than looking at this in detail, I’ll just leave these (small and not very numerous) files in for now. > - Similarly, Justfile and release.toml are only valuable for upstream > development. > > An exclusion rule for .cargo/, scripts/, Justfile, and release.toml might be > acceptable for upstream too. https://github.com/nextest-rs/datatest-stable/pull/424 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2423802 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202423802%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
