https://bugzilla.redhat.com/show_bug.cgi?id=2422784

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|ERRATA                      |---
              Flags|                            |needinfo?([email protected]
                   |                            |m)
                 CC|                            |[email protected]
             Status|CLOSED                      |POST
           Keywords|                            |Reopened



--- Comment #10 from Fabio Valentini <[email protected]> ---
Please address some minor issue with this package:

- The package doesn't document the downstream patch. Relaxing the dependency
from libc 1.0.0-alpha to 0.2 should be fine, but please document what the patch
does and why this is necessary.

- The Build/Requires for `pkgconfig(virglrenderer)` are superfluous. This is
already pulled in transitively via the package for the virglrenderer-sys crate.

(- It looks like you used a rust2rpm.toml config file - if it is non-empty
after removing the superfluous Build/Requires from the point above, please also
import it into dist-git, otherwise it's just lost and writing the config file
was pointless.)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2422784

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202422784%23c10

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to