https://bugzilla.redhat.com/show_bug.cgi?id=2398039
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected]) |needinfo?(solomoncyj@gmail. | |com) --- Comment #52 from Cristian Le <[email protected]> --- Please adjust the last few minor comments from my last comment > - Bundled packages versions are a bit off basing mostly on CMakeLists that I > see at corresponding commits: > - bundled(settings) should be 0.3.0 > - bundled(serialize) should be 0.1.0 > - bundled(magic_enum) should be 0.9.5 > - bundled(certify) should be 0.1 > - bundled(expected-lite) should be 0.9.0 > - You seem to have left out the first line in the license breakdown > (chatterino2: MIT AND BSD-3-Clause) Provides method technically works but it would not be picked up by some tools that check for specific rpm names like pkgs.org. I personally am fine with either and it can be changed anytime so that is not a blocker for me. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c52 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
