https://bugzilla.redhat.com/show_bug.cgi?id=2420917
--- Comment #2 from Parag AN(पराग) <[email protected]> --- Few suggestions: 1) Instead of patchelf use chrpath (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_removing_rpath) 2) somehow libraries are not getting installed as links libwhisper.so.1 file should be link to libwhisper.so.1.7.4 file libwhisper.so file should be link to libwhisper.so.1 file 3) Fix rpmlint issue of shebang You can fix all above in %install section as ------------ # Below files are not links to libwhisper shared library hence remove them rm -rf %{buildroot}%{python3_sitearch}/libwhisper.so rm -rf %{buildroot}%{python3_sitearch}/libwhisper.so.1 # Remove rpath from libraries chrpath --delete %{buildroot}%{python3_sitearch}/_pywhispercpp*.so chrpath --delete %{buildroot}%{python3_sitearch}/libggml*.so chrpath --delete %{buildroot}%{python3_sitearch}/libwhisper.so.1.7.4 # Create shared library links ln -sr %{buildroot}%{python3_sitearch}/libwhisper.so.1 %{buildroot}%{python3_sitearch}/libwhisper.so ln -sr %{buildroot}%{python3_sitearch}/libwhisper.so.1.7.4 %{buildroot}%{python3_sitearch}/libwhisper.so.1 # Remove shebang for file in %{buildroot}%{python3_sitearch}/pywhispercpp/{constants,model,utils}.py \ %{buildroot}%{python3_sitearch}/pywhispercpp/examples/{assistant,livestream,main,recording}.py; do sed -i -e '/^#!\//, 1d' $file done ------------ 4) Try to see if you can enable tests as %check %pyproject_check_import %pytest -vv 5) Also fix any other rpmlint issues Submit new package for further review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2420917 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202420917%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
