https://bugzilla.redhat.com/show_bug.cgi?id=2421973
--- Comment #4 from Neal Gompa <[email protected]> --- Initial spec review: > Version: 0.0 > Release: 2.%{commitdate}git%{shortcommit}%{?dist} This should use the newer SnapshotVersioning. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots It should look something like this in Version: "0.0~git%{commitdate}.%{shortcommit}" Then Release just looks normal. > # This builds an UEFI binary, not a Linux ELF binary, disable distro flags > unset CFLAGS > unset LDFLAGS This can be replaced with "%undefine _auto_set_build_flags" at the top of the spec. > make %{?_smp_mflags} Replace with "%make_build" > make install DESTDIR=$RPM_BUILD_ROOT Replace with "%make_install" > %{_prefix}/lib/%{name} > %{_datadir}/%{name} Please add a trailing slash so RPM tracks them as directories. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2421973 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202421973%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
