https://bugzilla.redhat.com/show_bug.cgi?id=2420488

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
             Status|NEW                         |POST
           Assignee|[email protected]    |[email protected]
                 CC|                            |[email protected]



--- Comment #3 from Neal Gompa <[email protected]> ---
Package review notes:

- Packaging follows Fedora packaging guidelines
- Packaging uses correct Rust macros for building and capturing licenses
- Package licensing is correct and license data is installed
- Package builds and installs (with local chain)
- No serious issues from rpmlint

PACKAGE APPROVED.

Suggestions for improving packaging before import:

- Split %meson into %conf stage
- Add a the typical GNOME package macro for translating Version to tarball
versions and drop %tag macro

%global tarball_version %%(echo %{version} | tr '~' '.')


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2420488

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202420488%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to