https://bugzilla.redhat.com/show_bug.cgi?id=2418814
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #4 from Fabio Valentini <[email protected]> --- Taking this review. Package looks pretty straightforward, just a few (very) minor things that aren't really blockers but just things I'd like to have clarified before approving: 1) IMO "written in Rust" is not very useful to put into "Summary" or %description. Consider just dropping it. 2) I assume that you might want to eventually also have a "signed" variant of sprout-unsigned-$arch? Is this why you already added Provides / Conflicts "%{name}-bootloader-%{efi_arch}"? 3) Is there a typo in "%{name}%{efi_arch}.efi"? Maybe not, it looks like grub also uses the "grubx64.efi" file name ... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418814 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418814%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
