https://bugzilla.redhat.com/show_bug.cgi?id=2419806
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Ben Beasley <[email protected]> --- The published crate is missing license files. This was fixed upstream in https://github.com/zowens/crc32c/commit/66c7c4905a6cf624cb1e1cbc21e7dd3cbce6faa1, but there hasn’t been a new release since then. You will need to add the license files from that commit as additional sources for now, similar to https://src.fedoraproject.org/rpms/rust-fax/blob/c29503f7445d80da0c868ca48af81e69408afc3c/f/rust2rpm.toml. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text The Summary “Safe implementation for hardware accelerated CRC32C instructions with software fallback” is too long, over 80 characters. You’ll need to come up with a shortened one. Perhaps “Safe implementation for hardware accelerated CRC32C with software fallback”. You can use package.summary in rust2rpm.toml for this. The patch crc32c-fix-metadata.diff should be accompanied by a comment saying what it does, why, and whether or not it is suitable for upstreaming, per https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/. You can use package.cargo-toml-patch-comments in rust2rpm.toml for this. Something like “Remove benchmark-only dev-dependencies on criterion and rand” should suffice. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2419806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202419806%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
