https://bugzilla.redhat.com/show_bug.cgi?id=2419403
--- Comment #9 from Miro Hrončok <[email protected]> --- Thanks. I see some other smells like %doc LICENSE (instead of %license LICENSE) and %defattr(-,root,root,-) Probably also with looking into using %make_build and %make_install (however, not sure if those are mandatory). I also highly recommend making patch 7 a -p1 patch and switching to %autosetup. Is there anything to be put into %check, even a simple smoke test? ----- Fedora review flagged: - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ The perl-clearsilver package depends on libperl.so.5.42()(64bit), so I think this satisfies the condition. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file CS_LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text That's what I already noticed. - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/clearsilver See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names This is an unretirement review, so we are good. rpmlint noticed: clearsilver.src: E: spelling-error ('templating', 'Summary(en_US) templating -> contemplating, template, tempting') clearsilver.src: E: spelling-error ('onelist', '%description -l en_US onelist -> one list, one-list, elision') clearsilver.src: E: spelling-error ('egroups', '%description -l en_US egroups -> groups, regroups, e groups') clearsilver.x86_64: E: spelling-error ('templating', 'Summary(en_US) templating -> contemplating, template, tempting') clearsilver.x86_64: E: spelling-error ('onelist', '%description -l en_US onelist -> one list, one-list, elision') clearsilver.x86_64: E: spelling-error ('egroups', '%description -l en_US egroups -> groups, regroups, e groups') perl-clearsilver.x86_64: E: spelling-error ('templating', 'Summary(en_US) templating -> contemplating, template, tempting') perl-clearsilver.x86_64: E: spelling-error ('templating', '%description -l en_US templating -> contemplating, template, tempting') ruby-clearsilver.x86_64: E: spelling-error ('templating', 'Summary(en_US) templating -> contemplating, template, tempting') ruby-clearsilver.x86_64: E: spelling-error ('templating', '%description -l en_US templating -> contemplating, template, tempting') All false positives. clearsilver.x86_64: W: no-manual-page-for-binary cs clearsilver.x86_64: W: no-manual-page-for-binary cs_static.cgi clearsilver.x86_64: W: no-manual-page-for-binary cstest I don't really care about those. clearsilver.spec: W: no-%check-section That would be nice. clearsilver.x86_64: W: install-file-in-docs /usr/share/doc/clearsilver/INSTALL That should probably be removed from %doc. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2419403 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202419403%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
