https://bugzilla.redhat.com/show_bug.cgi?id=2389097
Jaroslav Škarvada <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Jaroslav Škarvada <[email protected]> --- @fvorobev thanks for the proxy review. > [!]: Sources are verified with gpgverify first in %prep if upstream > publishes signatures. > NOTE: Package guidelines say that sources MUST be verified with > the %{gpgverify} macro. > See: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_verifying_signatures Yes, probably better to use the %gpgverify macro and IMHO it needs to be build required in any case. > [?]: Package should compile and build into binary rpms on all supported > architectures. Tested on koji (which IMHO non packagers cannot use) and it builds OK on all supported arches. > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > NOTE: Missing justification comment or link to upstream > bug/comments/lists. Yes, justification of the patch ant link to the upstream tracker would be useful here. Also mostly cosmetic: > %files devel I think it would be more legible to put it near the global %files section (i.e. after the %build and %install section). > make %{?_smp_mflags} Better to use the %make_build macro especially if you already use the %make_install macro later: %make_build > * Fri Aug 15 2025 You <[email protected]> - 0.3.0-1 You should use the real nick and email or use %autochangelog. @fvorobev I expect you to self-assign this bug and continue with the review / re-review once you become the fedora packager. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2389097 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202389097%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
