https://bugzilla.redhat.com/show_bug.cgi?id=2417719
--- Comment #7 from Than Ngo <[email protected]> --- >* %cmake_build is recommended over %make_build nowadays. This will be required >with CMake switching to Ninja by default, unless you explicitly set the target >to >"Unix Makefiles". The change >https://fedoraproject.org/wiki/Changes/CMake_ninja_default is supposed to be >implemented for Fedora 44, but does not seem to have >implemented in Rawhide >yet, since your Copr build succeeded. >* Likewise, you will want to use %cmake_install instead of "make install". (If >you really want to hardcode make, you can use "make install/fast", but see >above.) Hi Kevin, Both are not currently required, we can fix it later after automoc is readded to rawhide. Thank you for quick review :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2417719 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417719%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
