https://bugzilla.redhat.com/show_bug.cgi?id=2403018
--- Comment #6 from Neal Gompa <[email protected]> --- Initial spec review: > %setup -q This should be "%autosetup -p1" > pushd %{name} > cp -a usr %{buildroot}/ > pushd selinux > make install DESTDIR=%{buildroot} > popd > popd This can be simplified to the following: cp -a %{name}/usr %{buildroot}/ %make_install -C %{name}/selinux > %pre selinux > %selinux_relabel_pre -s %{selinuxtype} > [...] > %post selinux > %selinux_modules_install -s %{selinuxtype} > %{_datadir}/selinux/packages/%{selinuxtype}/%{modulename}.pp.bz2 > %selinux_relabel_post -s %{selinuxtype} > [...] > %postun selinux > if [ $1 -eq 0 ]; then > %selinux_modules_uninstall -s %{selinuxtype} %{modulename} > %selinux_relabel_post -s %{selinuxtype} > fi > [...] > %ghost %verify(not md5 size mode mtime) > %{_sharedstatedir}/selinux/%{selinuxtype}/active/modules/200/%{modulename} Shouldn't this cover all the policy types instead of just targeted, given how core it is? Also, the changelog entry format isn't quite right. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/manual-changelog/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2403018 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202403018%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
