https://bugzilla.redhat.com/show_bug.cgi?id=2388768
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #76 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- > %pre daemon > %tmpfiles_create_package nix-daemon > %{_builddir}/%{name}-%{version}/redhat-linux-build/src/nix/misc/systemd/nix-daemon.conf > > %pre filesystem > %tmpfiles_create_package nix-filesystem %SOURCE5 > > %pre system > %sysusers_create_package nix-system %SOURCE4 Are those all necessary? rpm has scriptlets to execute sysusers config (before package installation) and systemd has scriptlets to execute tmpfiles config (after transaction). So I think those are redundant in F42+. (In F41, systemd would execute sysusers config via %posttrans.) Those scripts shouldn't actually cause any harm… But I think they should be dropped unless necessary. Checklist: - package name is OK (nix) - license is acceptable for Fedora (LGPL-2.1-or-later) - license is specified correctly - latest upstream version — not entirely, we need a boost upgrade for the latest upgrade, but it's OK to trail momentarily. - BReq/Req/Prov/Rec look OK - builds and installs OK ;) - the binary is functional - %check is not present, but required dep is missing, so this is OK - systemd macros are used appropriately — mostly, see my comment above. - header files and libraries are properly split out - shared libraries are in %_libdir and have a version suffix We have the FESCo approval to use the dir. The text of the guidelines hasn't been updated yet, but we don't need to block on that and it seems this will take a while because of unrelated changes touching the same area. Package is APPROVED. -- Thank you for filing the change. I think it's good to do this to advertise. I made some small tweaks and changed the status to ReadyForWrangler. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2388768 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388768%23c76 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
