https://bugzilla.redhat.com/show_bug.cgi?id=2391549
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST --- Comment #11 from Cristian Le <[email protected]> --- Sorry Jerry, this one fell off my radar, please needinfo me if I have similar ones like this. Yes all looks good, thanks Andrew for picking it up. > Packaging documentation does seem to prefer Tox over pytest In general tox does not make sense for downstream testing because we do not test across different python versions or such. Sometimes there are configurations specific in the tox file, and generally we should encourage to move those to the pyproject.toml > There is no %license tag in the specfile, but the build is picking up the > LICENSE file on its own `%pyproject_install -l` (or the `BuildOption(install)` in this case) takes care of that. It will error out if the license flag from PEP639 is not present. It is very much build backend dependent though, so just trial-and-error if it works or not. > This seems to be doing all the traditional %prep, %build, %install steps > magically behind the scenes. Generally I would encourage it unless it is needed for epel9 and before. It allows the python sig to do more general changes behind the scene. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2391549 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202391549%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
