https://bugzilla.redhat.com/show_bug.cgi?id=2400067
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Ben Beasley <[email protected]> --- The spec-file diff shows that the issues found in the previous review were corrected: --- ../../srpm-unpacked/rust-serde-json-core.spec 2025-09-25 01:00:00.000000000 +0100 +++ srpm-unpacked/rust-serde-json-core.spec 2025-09-30 01:00:00.000000000 +0100 @@ -2,7 +2,7 @@ ## (rpmautospec version 0.8.1) ## RPMAUTOSPEC: autorelease, autochangelog %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: - release_number = 1; + release_number = 2; base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); print(release_number + base_release_number - 1); }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} @@ -24,6 +24,7 @@ Source: %{crates_source} BuildRequires: cargo-rpm-macros >= 24 +BuildRequires: dos2unix %global _description %{expand: Serde-json for no_std programs.} @@ -70,18 +71,6 @@ %files -n %{name}+custom-error-messages-devel %ghost %{crate_instdir}/Cargo.toml -%package -n %{name}+defmt-devel -Summary: %{summary} -BuildArch: noarch - -%description -n %{name}+defmt-devel %{_description} - -This package contains library source intended for building other packages which -use the "defmt" feature of the "%{crate}" crate. - -%files -n %{name}+defmt-devel -%ghost %{crate_instdir}/Cargo.toml - %package -n %{name}+heapless-devel Summary: %{summary} BuildArch: noarch @@ -108,6 +97,8 @@ %prep %autosetup -n %{crate}-%{version} -p1 +# Fix CRLF-terminated sources +find . -type f -exec dos2unix --keepdate '{}' '+' %cargo_prep %generate_buildrequires @@ -126,6 +117,10 @@ %changelog ## START: Generated by rpmautospec +* Tue Sep 30 2025 Andreas Schneider <[email protected]> - 0.6.0-2 +- Hide the defmt package +- Use dos2unix to convert from dos to unix file endings + * Thu Sep 25 2025 Andreas Schneider <[email protected]> - 0.6.0-1 - Initial package version 0.6.0 ## END: Generated by rpmautospec The output of fedora-review does not reveal any new problems, and there are no rpmlint messages. The package is therefore APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2400067 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202400067%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
