https://bugzilla.redhat.com/show_bug.cgi?id=2373132



--- Comment #6 from Benson Muite <[email protected]> ---
> - Please remove this comment:
>
>     # Fill in the actual package description to submit package to Fedora

Done

> - The "tests" extra is the kind of extra that we normally would not package as
>   a metapackage (python3-dict2xml+tests) even if its dependencies were
>   satisfiable, because it is not useful for other packages to depend on; see
>   
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_handling_extras.

>   Please remove this:

>    # Need python-noseofyeti
>    #pyproject_extras_subpkg -n python3-dict2xml tests

>   Furthermore, the tests no longer require noseofyeti as of 1.7.7, so you can
>   and should run them. Do not use the tests extra to generate dependencies,
>   because it pins an exact version of pytest.
>
>     -%pyproject_buildrequires #-x tests
>     +%pyproject_buildrequires
>
>   You *could* patch pyproject.toml to loosen the version bound, but since
>   pytest is now the only test dependency, it’s easier to simply list test
>   dependencies manually:
>
>     # The tests extra pins a precise version of pytest, which we cannot 
> respect; we
>     # therefore simply list test dependencies manually.
>     BuildRequires:  %{py3_dist pytest}
>
>   Now you can amend the %check section to look like this:
>
>     %check
>     %pyproject_check_import
>    %pytest

Done

Updated.

spec: https://fed500.fedorapeople.org/python-dict2xml.spec
srpm: https://fed500.fedorapeople.org/python-dict2xml-1.7.7-1.fc42.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2373132

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373132%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to