https://bugzilla.redhat.com/show_bug.cgi?id=2359651
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Ben Beasley <[email protected]> --- Just took a quick preliminary look at this while waiting for bug 2330715. > # FIXME: paste output of %%cargo_license_summary here > License: # FIXME You have to actually fill in the License field, like https://src.fedoraproject.org/rpms/rust-oxipng/blob/ed81c4e3e89ad4858fc99f288d65678870b78a9a/f/rust-oxipng.spec#_36. The command-line tool is not documented in the README, and practical testing suggests that it is not very polished, since it does not offer a usage message when I pass -h or --help, it ignores unexpected extra arguments, and it panics when it is passed too few arguments or a wrong algorithm name. > # textdistance hamming boat boar > 1 > # textdistance hamming boat boar asdf jhkl > 1 > # textdistance foo bar bat > > thread 'main' panicked at src/main.rs:49:14: > unknown algorithm name > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace > # textdistance hamming spam > > thread 'main' panicked at src/main.rs:7:26: > second text is required > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Honestly, I would be inclined to just ship only the library. This is easier for you anyway, since then you don’t have to deal with the License expression for the tool. In rust2rpm.toml, you could do something like: > [package] > # The command-line interface is not polished or well-documented, and it > appears > # to be intended primarily for experimentation during upstream development. > cargo-install-bin = false You should add comments explaining what the Cargo.toml metadata patch actually does: > # Manually created patch for downstream crate metadata changes > Patch: textdistance-fix-metadata.diff You can use rust2rpm.toml for this, too: > [package] > cargo-toml-patch-comments = [ > "Allow older foo until we can update, RHBZ#12345678", > "Remove benchmark-only dev-dependency bar", > ] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2359651 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202359651%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
