https://bugzilla.redhat.com/show_bug.cgi?id=2399640
--- Comment #12 from [email protected] --- (In reply to Benson Muite from comment #10) > > > Comments: > > > a) Please change > > > Source0: > > > https://github.com/ruyisdk/%{name}/releases/download/%{version}/%{name}- > > > %{version}.tar.gz > > > to > > > Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz > > > see: > > > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > > #_git_tags > > > b) Main concern is telemetry data. Environmental variable is set during > > > the > > > build, but this > > > probably does not persist when the package is installed. Perhaps a > > > configuration file could > > > be made and installed with the package? > > > c) Please update to the latest version > > > > Thank you for your review and suggestions. > > > > 1. The Source0 URL has been updated as recommended. > > > > Thanks. > > > 2. The environment variable set during installation is only used to support > > help2man. the software prompts the user on first launch to choose whether to > > enable telemetry. Would you recommend disabling telemetry by default? > > > > This would be better. Will examine the code again. > > > 3. The package has been updated to the latest version. > > > > Thanks. > > > Please let me know if there's anything else I should adjust. Thank you for pointing this out. I have updated the package so that telemetry is disabled by default. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399640 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399640%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
