https://bugzilla.redhat.com/show_bug.cgi?id=2400576
--- Comment #3 from Jerry James <[email protected]> --- (In reply to Benson Muite from comment #2) > b) Upstream does not seem to have a bug tracker, but there is a mailing list: > https://listserv.zib.de/mailman/listinfo/scip/ > Maybe some of the patches can be sent upstream and a message to update FSF > address > also sent. They do have a github repository; see the %giturl macro in the spec file. The first patch has already been applied upstream. The second patch appears to be a packaging difference between the Fedora nauty package and whatever distribution the gcg developers use; I'll see if something can be done about that. The third patch is Fedora-specific, to use flexiblas instead of the default gslcblas. The obsolete FSF address is no longer an issue, since upstream has relicensed to Apache-2.0 ahead of their 4.0 release, so all of those addresses have been removed. > c) Consider making the main package require library package so that the > license > file is always installed - it should be pulled in, but making the dependency > explicit > or also adding the license file to the main package would help ensure the > license > file is there even if there are changes to the package structure. I meant to do that. Thanks for catching the omission. > d) %{_includedir}/graph/ is generic, but does not conflict with anything at > present Yes, that worries me a little too, but, as you say, nothing else uses that name at present. If it becomes an issue in the future, we can push both directories into a gcg directory, so we would have /usr/include/gcg/gcg and /usr/include/gcg/graph. > e) Approved. Thank you for the review! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2400576 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202400576%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
