https://bugzilla.redhat.com/show_bug.cgi?id=2228190



--- Comment #25 from Benson Muite <[email protected]> ---
(In reply to Ibiam Chihurumnaya from comment #22)
> I've made some changes and have incorporated some of your suggestions.
> 
> b) I didn't register the name fill on PyPI, but I have installed it in
> %python3_sitelib that should be the perfect %libdir location for python
> packages right?
> 

As per guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
this is a blocker.

> c) Seeing as this isn't a blocker I don't think it needs to change, the .so
> files also don't qualify as "Prohibited Code" to me, correct me if I'm wrong.
> 

They are generated in the release process, though having extra unneeded
files in the source git repositories does waste space.  Ideally, the release
process would generate a version without library files, which could then be
used in Fedora.

> d) These errors no longer exist in my latest build.

Great.

> 
> e) Merged, thank you!
>

Ok.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2228190

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228190%23c25

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to