https://bugzilla.redhat.com/show_bug.cgi?id=2385991
--- Comment #5 from Dridi Boukelmoune <[email protected]> --- You can check out my branch: https://pagure.io/FedoraReview/pull-request/533 Then this should be enough to kick-start a review: python3 try-fedora-review -b 2385991 At least it WorksOnMyMachine™. I had a quick look and there is a lot of rpmlint noise that I addressed with this: $ cat hare.rpmlintrc # Empty READMEs allow empty modules to have submodules addFilter("zero-length /usr/src/hare/stdlib/.*/README") # Empty "tagged" source files can override "default" files addFilter("zero-length /usr/src/hare/stdlib/.*[.].*") # Multiple tags may need the same sources addFilter("files-duplicate /usr/src/hare/stdlib/.*") # False positive for hare-rpm-macros addFilter("only-non-binary-in-usr-lib") # This warning should be case-sensitive addFilter("name-repeated-in-summary Hare") There is also one failing check out of the box: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). But again, it looks like a false positive that could be automated away: --- /home/dridi/fedora/FedoraReview/2385991-hare/srpm/hare.spec 2025-09-20 00:05:47.623689505 +0200 +++ /home/dridi/fedora/FedoraReview/2385991-hare/srpm-unpacked/hare.spec 2025-07-28 02:00:00.000000000 +0200 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 7; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %undefine _auto_set_build_flags And another diff for %autochangelog. I have not looked at the remaining criteria myself. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2385991 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202385991%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
