https://bugzilla.redhat.com/show_bug.cgi?id=2336118
--- Comment #7 from Tim Flink <[email protected]> --- This review has been in progress for a while but it's basically complete. I have some concerns about this package but those don't affect the review much. 1. This is only built for a single ISA, unlike the rest of ROCm - This is a response to the crazy build time for this package. Enabling all the standard ISAs will cause the build to timeout in koji so we don't really have a choice on this one - c_k has a more narrow list of supported ISAs than most of the rest of the ROCm packages so there's not really a point in enabling more than what that specific upstream is willing to support - I don't know where to make note of this since it's not obvious unless you look at the specfile which most users won't do 2. The tests don't do terribly well for the single ISA that this is built for - This is not unique to the packaged form of c_k, building non-packaged, vanilla upstream for gfx1100 has the same failures 3. The structure of the optional test subpackage needs some tweaking - I'll just make these changes post-review, none of my concerns are in scope for the review, especially seeing as how the test subpackage is not built by default and can't be built in koji The only thing I want to see changed before approving the review is some sort of user-facing documentation about which ISA(s) the package is built for or at least a comment that it is more limited than the rest of ROCm. I don't care if it's in the description or some kind of README added to the package so long as it's somewhere that a user can reasonably find. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2336118 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202336118%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
