https://bugzilla.redhat.com/show_bug.cgi?id=2394056

Carl George 🤠 <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Carl George 🤠 <[email protected]> ---
FYI, this does qualify for a review exception under the third bullet point
here:

https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_package_review_exceptions

That said, I'm happy to review the specific aspects of making this one of these
special epel-only packages.

The gsub trick is neat, it almost feels like too much magic, but I can
understand the preference of doing that over listing out all the subpackages
manually just to change the requires.  I'm looking forward to using the
%python_extras_subpkg -v in the future.

Everything else checks out:

* no source or binary package name conflict with CentOS/RHEL
* no file conflicts with CentOS/RHEL
* no obsoletes or provides of CentOS/RHEL packages

To the extent I can approve a package that qualifies for a review exception,
PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2394056

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394056%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to