https://bugzilla.redhat.com/show_bug.cgi?id=2391300

Pavol Sloboda <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([email protected]
                   |                            |om)



--- Comment #21 from Pavol Sloboda <[email protected]> ---
I am unsure about this part of the spec file:
```
mkdir -p $HOME/.cargo/bin
```

because it writes outside of %{buildroot}, %{_builddir} and other temporary
locations as specified here[0].
$HOME gets expanded to /builddir during the build so it is not really a huge
issue but it is against the guidelines.
Looking into it I found the only option to get around this is creating it in a
valid directory and adding that to the 
`PATH` variable, I have not found any issues with this approach in the
packaging guidelines but it isn't great.
Could you please look into it and ask someone with more experience with rust
than me?

But I believe the creation of the directory inside of $HOME is against the
guidelines and should not be done.

[0]https://docs.fedoraproject.org/en-US/packaging-guidelines/#_scriplets_are_only_allowed_to_write_in_certain_directories


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2391300

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202391300%23c21

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to