https://bugzilla.redhat.com/show_bug.cgi?id=2382067

wojnilowicz <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+
                 CC|                            |[email protected]
                   |                            |m
           Assignee|[email protected]    |[email protected]
                   |                            |m



--- Comment #2 from wojnilowicz <[email protected]> ---
Package was generated with rust2rpm, simplifying the review.

Patches are justified.

Fedora review returns:
rust-rand_regex.src: W: strange-permission rand_regex-0.18.1.crate 666
rust-rand_regex.src: W: strange-permission rand_regex-fix-metadata.diff 666
rust-rand_regex.src: W: strange-permission rust-rand_regex.spec 666
but for me those files have 644 and not 666 permissions, so maybe something is
wrong with the tooling.

===

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (disabled with explanation)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

===

If you have time then please review
https://bugzilla.redhat.com/show_bug.cgi?id=2392155 in return.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2382067

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202382067%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to