https://bugzilla.redhat.com/show_bug.cgi?id=2363929

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
           Assignee|[email protected]    |[email protected]
                 CC|                            |[email protected]



--- Comment #4 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires

FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
TODO: Please replace perl-blib by 'perl(blib)'
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-File-ShareDir-Tiny-0.001-2.fc43.noarch.rpm | sort |
uniq -c | grep -v rpmlib
      1 perl(Carp)
      2 perl(Exporter) >= 5.57
      1 perl(File::Spec::Functions)
      1 perl-libs
      1 perl(strict)
      1 perl(warnings)
FIX: Remove duplicit definition of run-require perl(Exporter).

Otherwise binary requires are Ok.

$ rpm -qp --provides perl-File-ShareDir-Tiny-0.001-2.fc43.noarch.rpm | sort |
uniq -c
      1 perl(File::ShareDir::Tiny) = 0.001
      1 perl-File-ShareDir-Tiny = 0.001-2.fc43
Binary provides are Ok.

$ rpmlint ./perl-File-ShareDir-Tiny*
============================ rpmlint session starts
============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

perl-File-ShareDir-Tiny.src: E: spelling-error ('usr', '%description -l en_US
usr -> use, us, user')
 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 9 filtered, 1
badness; has taken 0.3 s
Rpmlint is ok

TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib}
directories
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new
spec file.

Resolution:
NOT Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2363929

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363929%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to