https://bugzilla.redhat.com/show_bug.cgi?id=2363808

Benson Muite <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #13 from Benson Muite <[email protected]> ---
Good feedback.

Please replace
Source0:        %{url}/releases/download/v%{version}/%{name}-%{version}.tar.gz
by
Source0:        %{url}/archive/%{version}/trafix-%{version}.tar.gz

see
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags
could also use forge macros
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control

To preserve timestamps, replace
install -Dm644 man/trafix.1 %{buildroot}%{_mandir}/man1/trafix.1
install -Dm644 config/config.cfg %{buildroot}/etc/trafix/config.cfg

by

install -Dpm644 man/trafix.1 %{buildroot}%{_mandir}/man1/trafix.1
install -Dpm644 config/config.cfg %{buildroot}/etc/trafix/config.cfg


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2363808

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363808%23c13

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to