https://bugzilla.redhat.com/show_bug.cgi?id=2360119



--- Comment #37 from Fabio Valentini <[email protected]> ---
> Please add "%bcond check 1" (or "0" if you can't run tests, and document 
> *why*) at the top of the spec file.

I didn't write it like that for funsies. Some of the RPM macros from
cargo-rpm-macros *rely* on the bcond being named "check".

For example, the fact that the %cargo_generate_buildrequires macro currently
works with the "run_tests" bcond is purely accidental.

So I would recommend to either use a "check" bcond instead, *or* pass "-t" to
%cargo_generate_buildrequires to unconditionally include test-only
dependencies.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2360119

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360119%23c37

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to