https://bugzilla.redhat.com/show_bug.cgi?id=2369466



--- Comment #17 from TomasJuhasz <[email protected]> ---
Few small rpmlint complains:
1.) Non-executable npm scripts.
> nodejs24-npm.noarch: E: non-executable-script 
> /usr/lib/node_modules_24/npm/lib/utils/completion.sh 644 /bin/bash
and other javascript/python files on path: 
> /usr/lib/node_modules_24/npm/

Caused by this block (line 411):
># === NPM installation and tweaks
># Correct permissions in provided scripts
># - There are executable scripts for Windows PowerShell; RPM would try to pull 
>it as a dependency
># - Not all executable bits should be removed; the -not -path lines are the 
>ones that will be kept untouched
>declare NPM_DIR="${RPM_BUILD_ROOT}%{nodejs_common_sitelib}/npm"
>find "${NPM_DIR}" \
>    -not -path "${NPM_DIR}/bin/*" \
>    -not -path "${NPM_DIR}/node_modules/node-gyp/bin/node-gyp.js" \
>    -not -path 
> "${NPM_DIR}/node_modules/@npmcli/run-script/lib/node-gyp-bin/node-gyp" \
>    -type f -executable \
>    -execdir chmod -x '{}' +

Used to remove permissions from power-shell scripts (e.g.
/usr/lib/node_modules_24/npm/bin/npm.ps1), but it's probably not necessary as
these already don't have execute privileges.

2.) Spelling of ICU
>nodejs24-full-i18n.x86_64: E: spelling-error ('icu', '%description -l en_US 
>icu -> ICU, icy, Cu')
3.) Empty roadmap file
>nodejs24-npm.noarch: E: zero-length 
>/usr/lib/node_modules_24/npm/node_modules/smart-buffer/docs/ROADMAP.md
(Empty file created 7 years ago and never used - maybe eventually it could be
stripped during creation of tarball, but probably not a high priority.)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2369466

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202369466%23c17

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to