https://bugzilla.redhat.com/show_bug.cgi?id=2371335



--- Comment #2 from Jakub Kadlčík <[email protected]> ---
> - License file LICENSE.md is not marked as %license
>  Read more: 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

I don't know about this. I can't see any LICENSE.md file anywhere. Maybe a
false-positive?


> %check

The example spec file at
https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_example_spec
runs tests with

    # Run tests/
    ./node_modules/.bin/tap test/*.js

but our tarball doesn't have the test directory. Upstream has it but not the
npm registry tarball. I would keep the spec as is.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2371335

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371335%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to